Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add is-a.dev #1949

Merged
merged 3 commits into from
Apr 10, 2024
Merged

chore: add is-a.dev #1949

merged 3 commits into from
Apr 10, 2024

Conversation

wdhdev
Copy link
Contributor

@wdhdev wdhdev commented Mar 22, 2024

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

is-a.dev is a free subdomain service for developers. We offer subdomains on the domain is-a.dev to all developers for their personal websites and portfolios.

Organization Website:

https://www.is-a.dev
https://github.com/is-a-dev/register

Reason for PSL Inclusion

Original PR: #1327

We are seeking to get our domain is-a.dev added to the Public Suffix List since it is a public domain service available to everyone.

I am an administrator of the is-a.dev project.

One of the main reasons we would like to be included on this list is cookie separation, cookie separation will allow all cookies across our users subdomains to remain separate and to prevent potential security risks between subdomains.

Another reason for why we should be added is, users are unable to use services such as Vercel and Netlify due to those services requiring root domain verification even when using a subdomain on their service. This is because the services use the Public Suffix List (as far as I'm aware) and do not recognise our domain as a public suffix.

This project is very similar in what we offer to services such as https://eu.org and https://js.org which are already on the PSL.

Number of users this request is being made to serve:

Currently over 2,660 individuals, with the count growing everyday.

DNS Verification via dig

dig +short TXT _psl.is-a.dev
"https://github.com/publicsuffix/list/pull/1949"

Results of Syntax Checker (make test)

All tests passed.


Please note, the submitter email is the service owner's email address, not mine. I am using that email address as he is the one to contact if there is any issues.

@orangci
Copy link

orangci commented Mar 22, 2024

Whoever approves this PR is extremely based.

@YouFoundAlpha
Copy link

Let's hope it gets approved

@omsenjalia
Copy link

REALLY GOOD SERVICE. i hope it gets approved

@CuteDog5695
Copy link

Hope this gets approved

@SX-9
Copy link

SX-9 commented Mar 22, 2024

approve please

@Glqch0
Copy link

Glqch0 commented Mar 22, 2024

He listed every possible reason it SHOULD be added, please approve

@SukiPlayz
Copy link

approve this service please

@simon-friedberger
Copy link
Contributor

Can you please contact Netlify and Vercel? Or provide a link to their docs?
We need to keep track of how people use the PSL and make sure it's appropriate.

@simon-friedberger
Copy link
Contributor

simon-friedberger commented Mar 27, 2024

  • Expiration (Note: Must STAY >2y at all times)
    • is-a.dev expires 2031-10-03
  • DNS _psl entries (Note: Must STAY in place)
  • Tests pass
  • Sorting
  • Reasoning/Organization description

@simon-friedberger
Copy link
Contributor

This project is very similar in what we offer to services such as https://eu.org/ and https://js.org/ which are already on the PSL.

If these are all "you". Why are they not under the same organization?

@omsenjalia
Copy link

This project is very similar in what we offer to services such as https://eu.org/ and https://js.org/ which are already on the PSL.

If these are all "you". Why are they not under the same organization?

They are "Similar" to what subdomains we provide. We do not come from the name owner nor the same orginization.

@wdhdev
Copy link
Contributor Author

wdhdev commented Mar 27, 2024

Can you please contact Netlify and Vercel? Or provide a link to their docs? We need to keep track of how people use the PSL and make sure it's appropriate.

Vercel checks the apex domain even if you are using a subdomain and no one else is using the root domain. If is-a.dev was listed on the PSL it will fix this as it will recognise .is-a.dev subdomains as individual domains instead of just subdomains. (ref: https://vercel.com/docs/projects/domains/troubleshooting#domain-ownership-errors)

With Netlify, I cannot find a doc page however, I can tell you that it does the same as Vercel regarding domain ownership.

@simon-friedberger
Copy link
Contributor

Just as a note, comments of the form "+1" or "approve this" really don't add any value. ;)

@simon-friedberger simon-friedberger added ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger labels Mar 27, 2024
@wdhdev
Copy link
Contributor Author

wdhdev commented Mar 27, 2024

Just as a note, comments of the form "+1" or "approve this" really don't add any value. ;)

Yeah I know. I didn't ask people to do that if that's what you're thinking. People just did that after I announced we applied for the PSL.

@Gen1x-ALT
Copy link

approve this

@dnsguru
Copy link
Member

dnsguru commented Mar 28, 2024

piling on comments is actually slowing approval / merging as it all gets reviewed holistically, and may start the review over, so unless there is interest in delay, please stop 'nudging'

@wdhdev
Copy link
Contributor Author

wdhdev commented Mar 28, 2024

@dnsguru Can you lock the conversation? (Once again, I'm not asking people to do this.)

@simon-friedberger simon-friedberger merged commit 067d510 into publicsuffix:master Apr 10, 2024
1 check passed
@publicsuffix publicsuffix locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.