Add Github workflow to check _psl DNS entries on PRs

[simon-friedberger]

Let's have more automatic checks!

[weppos]

Hi @simon-friedberger, can you provide a bit more context about this PR. Is there a conversation somewhere about it? What's the purpose of this script, and what is the expectation?

I also wonder, I see it was developed in Python. Is it because that's the language you are most familiar with, or is there another reason? I am asking as we had Python code in the past but it was not really the most preferred language and we moved most of the tooling to Go. I am a bit concerned about adding more Python again, for the long term maintainability.

[dnsguru]

@simone I asked simon to pause this... There is a separate dialog with google about development of automation which I believe was go-based - I have shared the diagrams and specs I took time to develop in the hopes of avoiding parallel evolution costing valuable volunteer cycles

…

On Mon, Feb 19, 2024 at 12:45 AM Simone Carletti ***@***.***> wrote: Hi @simon-friedberger <https://github.com/simon-friedberger>, can you provide a bit more context about this PR. Is there a conversation somewhere about it? What's the purpose of this script, and what is the expectation? I also wonder, I see it was developed in Python. Is it because that's the language you are most familiar with, or is there another reason? I am asking as we had Python code in the past but it was not really the most preferred language and we moved most of the tooling to Go. I am a bit concerned about adding more Python again, for the long term maintainability. — Reply to this email directly, view it on GitHub <#1933 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQTJPNCCBSB7JIKKCKEOTYUMGLPAVCNFSM6AAAAABDBKIXMSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRHE3DANJUGI> . You are receiving this because your review was requested.Message ID: ***@***.***>

[simon-friedberger]

I am not against using Go for this if that is the project preference. Python was just the natural choice for me.

[dnsguru]

I am not against using Go for this if that is the project preference. Python was just the natural choice for me.

Same thought, as go is less familiar to me, but want to minimize complexity with >1 approaches at this point so we don't add interop burdens

[simon-friedberger]

The submission by Sam here is also in Python and @dnsguru has expressed support. Can I go ahead with this?

[dnsguru]

After discussion, this looks like a good idea - accompanied by test suite elements to know about impacts. The automation work is really appreciated

[dnsguru]

I suggested a TLD and TLD w a sld wildcard in the examples for the test suite

I was also thinking of IDN support. Upon some contemplation, I believe IDN scenarios would function identically to their LDH equivelents in the test suite. Just documenting here that IDN was considered. Adding them here would be placebo; cosmetic-only, require additional dependencies/libraries/modules, add complexity and not have any difference in outcome, so would not deliver any value or benefit in exchange for the overhead.

[simon-friedberger]

As soon as I get to it we should merge this with parsing and checks for individual rules in the linter here https://github.com/publicsuffix/list/blob/master/linter/pslint.py that should cover IDN issues.

[simon-friedberger]

@weppos Please have a look!