-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Submissions to the Public Suffix List - Q1 2024 #1919
Conversation
@dnsguru / @simon-friedberger: kind nudge, it's been a few weeks since we've moved this from draft to open. We saw that several other PRs have been actioned/merged in the meantime while ours is still labeled as Draft, so we wanted to follow up. In the short term, should we add to our internal SOPs to post a comment to our PR mentioning the maintainers when we move from draft -> open? We have been intentional about reducing our pings to the maintainers to prevent excess noise, but we understand how this kind of active notification might be helpful for your team. In the longer term, is it worth revisiting the use of the |
Hi @aph3rson yes please add to sop there at the point these move from draft to open and also @dnsguru and @simon-friedberger so we have some indication that the PR has been identified by AWS as ready to review. Otherwise it blends into the noise. There are no service levels pledged or anything of the like. We are still volunteer maintainers and review of AWS / "Amazon and family" submissions typically have a lot to look at in contrast to other submitters. The sheer volume of entries AWS has in the file is larger than most all other requestors, and there is gratitude for how your team has become the single point for across the various managed namespaces. I think your idea will help... add a comment mentioning Simon and I that states |
@dnsguru - noted, thanks for the context. We've updated our SOPs, and will add a comment when moving our pull request from draft -> open going forward. On the topic of longer-term - would some automation that automatically manages the draft <-> open transitions be helpful? Our thoughts on how that automation might look:
Implementation of this should be feasible via GitHub Actions with a short workflow. We’ve been doing some proof of concept work for such a workflow and would gladly provide a code sample to help reduce developer pain on the maintainers. |
|
We discussed this PR among the reviewing volunteers, and it was determined that it would be proceeding to merge, but to be honest, there's a lot involved in these, sooo much more resource/time than other requestors that we have to invest, often finding domains that do not have the _PSL txt records in place or those that do not have the +2Y on them that we have to iterate or make exceptions for. As I read your suggestions, I had perhaps misread that they were things being performed within AWS on their own pull request. Now as I read it, the suggestion was that we automate PR flow. Automation of nags has low allure, as there are other, higher priority automations and test suites that are more pronounced technical debt here that could allow for more efficient processing - which would help things along generally. Currently in the queue for automation are the validation of NS _PSL TXT and intra-section sorting. |
Public Suffix List (PSL) Pull Request (PR) Template
Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.
Checklist of required steps
Submitter affirms the following:
AWS does not submit suffixes to the Public Suffix List to work around rate-limits of any third-party products or tooling.
Please see the Reason section below for objectives in this pull request.
For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.
To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.
PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.
(Link: about propagation/expectations)
Description of Organization
Amazon Web Services (AWS) is the world’s most comprehensive and broadly adopted cloud, offering over 200 fully featured services from data centers globally. More information about AWS is available on our website: What is AWS?
Organization Website: AWS Homepage
Reason for PSL Inclusion
These features/services have been identified by AWS Security and AWS service teams as supporting different distinct customers/resources across shared DNS suffixes. Adding these suffixes to the PSL is expected to improve the security posture of customers using our services. This may include:
Number of users this request is being made to serve:
These changes are expected to impact all customers using these AWS services. This includes both AWS-internal and external customers. Specific user counts for these listed features/services are not publicly available.
Services/Features in PR:
DNS Verification via dig
DNS query results
Results of Syntax Checker (
make test
)Test results