Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure updates for Microsoft Corporate Domains #1891

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

edwa001
Copy link
Contributor

@edwa001 edwa001 commented Nov 8, 2023

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Microsoft Azure is the world's computer. Microsoft empowers every individual and every organization on earth to achieve more.

Organization Website:

https://www.microsoft.com/

Reason for PSL Inclusion

We seek to have segmentation of these namespaces to appropriately isolate cookie and other divisions within browsers and applications. Similar to prior requests made by or on behalf of the Corporate Domains division at Microsoft, these requests contribute to the stable, secure and resilient operation of Azure on behalf of its customers and partners.

Number of users this request is being made to serve:

Azure currently supports millions of users.

DNS Verification via dig

Results of Syntax Checker (make test)

@dnsguru dnsguru self-assigned this Nov 8, 2023
@dnsguru dnsguru added the NOT IOS FB Submitter attests PR is not #1245 related label Nov 8, 2023
@dnsguru dnsguru self-requested a review November 8, 2023 23:53
dnsguru
dnsguru previously requested changes Nov 8, 2023
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove East Asia?

@dnsguru dnsguru dismissed their stale review November 8, 2023 23:59

I missread the diff summary, please disregard

@dnsguru dnsguru added the ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important label Nov 9, 2023
@dnsguru
Copy link
Member

dnsguru commented Nov 9, 2023

Please notify us when the DNS TXT records are in place

@dnsguru
Copy link
Member

dnsguru commented Nov 9, 2023

This has been reviewed via telephone call to MS Corporate Domains Division to confirm this was submitted with their understanding and approval.

@mozfreddyb
Copy link
Contributor

This has been reviewed via telephone call to MS Corporate Domains Division to confirm this was submitted with their understanding and approval.

In the interest of transparency, what did that validation look like? Do you have their number or do they have yours?
Does this skip any of the other validation or do we still expect them to have _psl TXT records (I hope the latter).

How do we want that process to look like in the future?

@dnsguru
Copy link
Member

dnsguru commented Nov 9, 2023 via email

@simon-friedberger
Copy link
Contributor

This would be a great opportunity to ensure that all MS domains have a _psl. DNS entry.

@dnsguru
Copy link
Member

dnsguru commented Nov 10, 2023 via email

@dnsguru
Copy link
Member

dnsguru commented Jan 7, 2024

Hi @edwa001 - in performing reviews of the DNS I noticed that the proof items were not present in doing the TXT record look ups to correspond with the request. Working from the bottom up in the request, I checked the last three entries.

$ nslookup -type=txt _psl.servicebus.windows.net
Server:		1.1.1.1
Address:	1.1.1.1#53

** server can't find _psl.servicebus.windows.net: NXDOMAIN

$ nslookup -type=txt _psl.blob.core.windows.net
Server:		1.1.1.1
Address:	1.1.1.1#53

** server can't find _psl.blob.core.windows.net: NXDOMAIN

$ nslookup -type=txt _psl.trafficmanager.net
Server:		1.1.1.1
Address:	1.1.1.1#53

** server can't find _psl.trafficmanager.net: NXDOMAIN

@@ -14077,7 +14077,13 @@ co.pl

// Microsoft Corporation : http://microsoft.com
// Submitted by Public Suffix List Admin <[email protected]>
// Managed by Corporate Domains
// Microsoft Azure : https://home.azure
cloudapp.azure.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since domains issued on cloudapp.azure.com are in the format <label>.<region>.cloudapp.azure.com shouldn't the rule be *.cloudapp.azure.com so that domains issued to vms in the same region are treated as different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for calling that out, I have updated it to the wildcard

Added a wildcard for cloudapp.azure.com
@edwa001
Copy link
Contributor Author

edwa001 commented Jan 12, 2024

Due to a misunderstanding the validation records have been added under the root of each domain. I will work on getting the _psl records added however there is a lot of bureaucratic process involved and it may take a while. Will the domain root validation records work for the sake of this pull request?

@edwa001
Copy link
Contributor Author

edwa001 commented Jan 12, 2024

@dnsguru As I updated one of the entries to a wildcard, can you please help validate the ordering once more?

*.cloudapp.azure.com
azure-api.net
azureedge.net
azurefd.net
azurewebsites.net
azure-mobile.net
cloudapp.net
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwa001 please drop cloudapp.net to just above trafficmanager.net

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated order as requested

@edwa001 edwa001 requested a review from dnsguru January 31, 2024 00:20
@dnsguru
Copy link
Member

dnsguru commented Feb 1, 2024

Perfect. Good to go.

@dnsguru dnsguru added r=dnsguru Marked as approved and ready to merge by @dnsguru ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# labels Feb 2, 2024
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Sorted to Guidelines
  • DNS TXT = Pull Request URL
  • Tests Pass
  • No conflict with base

APPROVED

@dnsguru dnsguru merged commit 8b50ed0 into publicsuffix:master Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# NOT IOS FB Submitter attests PR is not #1245 related r=dnsguru Marked as approved and ready to merge by @dnsguru ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

5 participants