Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused suffix (123sait.ru) #1844

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jacobbunk
Copy link
Contributor

@jacobbunk jacobbunk commented Sep 4, 2023

Public Suffix List (PSL) Pull Request (PR) Template

Each PSL PR needs to have a description, rationale, indication of DNS validation and syntax checking, as well as a number of acknowledgements from the submitter. This template must be included with each PR, and the submitting party MUST provide responses to all of the elements in order to be considered.

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

One.com - a large hosting company that mainly operations in Northern Europe, recently acquired SimpleSite a web hosting company focused on providing web hosting based on their simple site builder. One.com is part of group.one that also operates the .one TLD as well as several other hosting brands that can be found at the https://group.one website.

I, the submitter, Jacob Bunk Nielsen work in the engineering team of one.com.

Organization Website: https://www.one.com/

Reason for PSL Inclusion

Removing as this no longer have to be considered a public suffix. It was submitted by me as part of #1623

Number of users this request is being made to serve: none

DNS Verification via dig

$ dig +short txt _psl.123sait.ru @1.1.1.1
"https://github.com/publicsuffix/list/pull/1844"

Results of Syntax Checker (make test)

Ended badly, but I get a similar result on the master branch and can't imagine removing a domain from the list would cause this:

configure.ac:1: warning: file `version.txt' included several times
configure.ac:4: warning: file `version.txt' included several times
aclocal.m4:489: AM_INIT_AUTOMAKE is expanded from...
configure.ac:4: the top level
configure.ac:383: warning: file `version.txt' included several times
configure.ac:67: error: possibly undefined macro: AC_MSG_ERROR
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
configure.ac:92: error: possibly undefined macro: AC_LINK_IFELSE
configure.ac:93: error: possibly undefined macro: AC_LANG_PROGRAM
configure.ac:196: error: possibly undefined macro: AC_SEARCH_LIBS
configure.ac:225: error: possibly undefined macro: AC_MSG_CHECKING
configure.ac:230: error: possibly undefined macro: AC_MSG_RESULT
autoreconf: error: /usr/bin/autoconf failed with exit status: 1
make: *** [Makefile:18: libpsl-config] Error 1

@jacobbunk
Copy link
Contributor Author

Clicked the last 3 checkboxes even though they are irrelevant in the context of PSL removal.

@dnsguru dnsguru added the 😭rollback Requestor seeking to remove or revise an entry label Oct 2, 2023
@jacobbunk
Copy link
Contributor Author

@dnsguru - is more work required to merge this one?

It comes from a company acquisition where subdomains under this domain were sold to individual customers (without proper inclusion in PSL), but after we merged the companies and cleaned up the data this one turned out to no longer be needed.

@dnsguru dnsguru self-assigned this Feb 28, 2024
@simon-friedberger
Copy link
Contributor

Can you please add the DNS verification entry?

@jacobbunk
Copy link
Contributor Author

Can you please add the DNS verification entry?

Done, also updated description with the validation query.

@simon-friedberger simon-friedberger added ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger labels Mar 11, 2024
@simon-friedberger simon-friedberger merged commit 49e0620 into publicsuffix:master Apr 10, 2024
1 check passed
@jacobbunk jacobbunk deleted the cleanup branch April 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger 😭rollback Requestor seeking to remove or revise an entry
Projects
Status: Done or Won't
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

3 participants