Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: can.re #1651

Merged
merged 4 commits into from
Apr 10, 2024
Merged

ADD: can.re #1651

merged 4 commits into from
Apr 10, 2024

Conversation

OsSav
Copy link
Contributor

@OsSav OsSav commented Nov 19, 2022

Checklist of required steps

  • Description of Organization

  • Robust Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place in the respective zone(s) in the affected section

Submitter affirms the following:

  • We are listing any third-party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third-party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting and sorting

For Private section requests that are submitting entries for domains that match their organization website's primary domain, please understand that this can have impacts that may not match the desired outcome and take a long time to rollback, if at all.

To ensure that requested changes are entirely intentional, make sure that you read the affectation and propagation expectations, that you understand them, and confirm this understanding.

PR Rollbacks have lower priority, and the volunteers are unable to control when or if browsers or other parties using the PSL will refresh or update.

(Link: about propagation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

can.re - Expiry Date: 2031 year,
official e-mail [email protected] always works.
Website: https://nic.can.re/ (under construction)
We offer various Internet services for our customers. We create new zone " .can.re", so we would like these zone to be on the public suffix list as well as others zones " .(*).re ".
Organization Name: OsSav Technology Ltd.
Organization Website: https://ossav.com
Number of users this request is being made to serve:
Current: 1560+
Estimated in one year:: 15000+

Reason for PSL Inclusion

Users can register domains in the domain can.re.
which means subdomains (*.can.re) are registered by independent 3rd parties.
We want user subdomains to be isolated from each other (cookies, suffix allocation, etc.). The domain is registered until 2031 year.

Raports:
https://dnssor.com/nic.can.re/whois
https://toolbox.googleapps.com/apps/dig/#NS/nic.can.re
https://www.google.com/search?q=site%3A*.can.re
https://dnssor.com/nic.can.re
https://intodns.com/nic.can.re
https://toolbox.googleapps.com/apps/dig/#NS/nic.can.re
https://transparencyreport.google.com/safe-browsing/search?url=can.re
https://en.wikipedia.org/wiki/.re
Whois: https://dnssor.com/nic.can.re/whois
DNS Report: https://intodns.com/nic.can.re
Full DNS Report: https://dnssor.com/nic.can.re
History: https://dnssor.com/nic.can.re/history

DNS Verification via dig

dig +short TXT _psl.can.re
"https://github.com/publicsuffix/list/pull/1651"

Results of Syntax Checker (make test)

============================================================================
Testsuite summary for libpsl 0.21.1
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-public-all.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public
  CCLD     test-is-public-all
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-public
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.1
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for resubmitting. Can you place this higher in the #PRIVATE section of the file, so that it is sorted alphabetically by your org name among the other org names instead of at end of the file?

@OsSav
Copy link
Contributor Author

OsSav commented Nov 19, 2022

Thank you for resubmitting. Can you place this higher in the #PRIVATE section of the file, so that it is sorted alphabetically by your org name among the other org names instead of at end of the file?

694.line added:
// can.re : https://nic.can.re/
// Whois Server : whois.can.re
// Submitted by OsSav Technology Ltd. : [email protected]
can.re

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an inappropriate addition location ; it is for direct IANA / ICANN delegation and you cannot add the entry here

Please place this lower in the file, in the #private section, alphabetically sorted by org name.

@dnsguru dnsguru added the ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important label Nov 22, 2022
@dnsguru dnsguru changed the title ADD: can.re ADD: can.re Nov 22, 2022
@OsSav
Copy link
Contributor Author

OsSav commented Nov 23, 2022

#private

I apologize for the mistake. I missed this detail. I fixed it.
Alphabetical addition was made under Private.

@OsSav OsSav requested a review from dnsguru November 24, 2022 22:26
@dnsguru
Copy link
Member

dnsguru commented Nov 25, 2022 via email

@dnsguru dnsguru added NOT IOS FB Submitter attests PR is not #1245 related and removed ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Nov 29, 2022
@OsSav
Copy link
Contributor Author

OsSav commented Feb 3, 2023

@dnsguru Will this process take too long? According to other requests, there are many more users using our service than other requests. As of now, there are over 2k users. For this reason, it is a bit urgent. Thank you for your understanding.

Copy link

@yoncu yoncu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request seems to be appropriate and needs to be prioritized.

Copy link
Contributor

@simon-friedberger simon-friedberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Expiration
    • can.re expires 2031-10-27
  • DNS _psl entries
  • Tests pass
  • Sorting
  • Reasoning/Organization description

@@ -11127,6 +11127,11 @@ radio.fm
// c.la : http://www.c.la/
c.la

// can.re : https://nic.can.re/
// Whois Server : whois.can.re
// Submitted by OsSav Technology Ltd. : [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting is by organization name

@simon-friedberger simon-friedberger added ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important ✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger labels Feb 5, 2024
Sort by organization name request implemented.
@simon-friedberger simon-friedberger added ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important and removed ❌FAIL - FIX SORTING ⏬ https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important labels Feb 5, 2024
@simon-friedberger simon-friedberger merged commit f5416ed into publicsuffix:master Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✔️DNS _psl Validated RFC 8553 Entries were present, matching PR# NOT IOS FB Submitter attests PR is not #1245 related r=simon-friedberger Marked as approved and ready to merge by @simon-friedberger ✔️Sorting Validated https://github.com/publicsuffix/list/wiki/Guidelines#sort-your-submission-correctly-important
Projects
Status: Done or Won't
Development

Successfully merging this pull request may close these issues.

4 participants