Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StripTrailingHostDot: Expose new configuration option to enable Envoy removal of trailing dot on hostnames #6792

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

saley89
Copy link

@saley89 saley89 commented Nov 27, 2024

Fixes #6334

This PR adds:

  • A new configuration option in the NetworkParameters of Contour.
  • The new option is called StripTrailingHostDot.
  • This option when set to true will configure all Envoy routing to strip any trailing dot from a hostname before processing the request. This will allow it to be matched by any existing routes for that hostname without a dot.
  • Tests to show the configuration option set to to true being added to the underlying listener configuration.

@saley89 saley89 requested a review from a team as a code owner November 27, 2024 09:44
@saley89 saley89 requested review from tsaarni and skriss and removed request for a team November 27, 2024 09:44
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and izturn and removed request for a team November 27, 2024 09:44
Copy link

Hi @saley89! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to path returning 404 for trailing dot domain
1 participant