Make test suite ready for NumPy 2.0.0 #4622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Jul 25, 2024
| @@ -6,7 +6,7 @@ | |||
| from datetime import datetime as dt | |||
| import numpy as np | |||
|
|
|||
| np_list = np.array([1, 2, 3, np.NaN, np.NAN, np.Inf, dt(2014, 1, 5)]) | |||
| np_list = np.array([1, 2, 3, np.nan, np.inf, dt(2014, 1, 5)]) | |||
There was a problem hiding this comment.
I think we need to have separate tests for both numpy v1 and v2.
There was a problem hiding this comment.
In #4696 @marthacryan added a CircleCI test for the case when numpy is not installed.
Instead of changing the tests that use numpy_v1, what I want to see is to add tests for numpy_v2.
|
@bnavigator Is it okay if I push some changes here to handle both versions of numpy? |
Yes, of course. Sorry I do not have time to enhance it myself right now. |
gvwilson
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soon to be released NumPy 2.0.0 removes some aliases of
np.nanandnp.inf, so these must be removed from the tests in order to keep the test suite green.Also, when testing data with small integer types like
int8, the literals need to be cast beforehand in order to avoid overflow errors.References
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.For a new feature, I have added documentation examples in an existing ornew tutorial notebook (please see the doc checklist as well).
I have added a CHANGELOG entry if fixing/changing/adding anything substantial.For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).