Fix box trace with "all" points and line_width=0 doesn't render marker in legend #7162
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvwilson
added
community
emilykl
reviewed
Sep 26, 2024
| } | ||
| }, | ||
| "hoveron": "points" | ||
| } | ||
| ], | ||
| "layout": { | ||
| "legend": { |
There was a problem hiding this comment.
Thank you for the contribution @jnumainville ! This is a great fix.
Let's add "orientation": "h" to the legend spec so that the legend doesn't overlap the data points.
There was a problem hiding this comment.
I couldn't get that to work for some reason, not sure what I was doing wrong, so I flipped the "y" to "x" in the traces, hopefully that works.
|
That image shows an error for me but I went into circleci and pulled the image I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7159 with both the
boxandviolin, so now points show up in the legend whenfillcoloris transparent,linewidthis 0, andpoints/boxpointsis set to"all"