Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node.js v18 and npm v10 in development #7078

Merged

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Aug 8, 2024

This PR updates to Node 18, which is in maintenance mode until April 30th 2025.

Overview here: https://endoflife.date/nodejs

Closes #7081

.circleci/config.yml Outdated Show resolved Hide resolved
draftlogs/7078_change.md Outdated Show resolved Hide resolved
@birkskyum birkskyum force-pushed the Use-node.js-v18-and-npm-v10-in-development branch from 2925d31 to 6eaa057 Compare August 8, 2024 19:19
@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 8, 2024

@archmoj , do you have any idea why the firefox browser won't start in the mathjax-firefox tests?

@archmoj
Copy link
Contributor

archmoj commented Aug 8, 2024

@archmoj , do you have any idea why the firefox browser won't start in the mathjax-firefox tests?

I could have a look. Perhaps since those specific versions of firefox are old now they may not be available on new containers or something else.

In the meantime, I appreciate it if you could have a second look at #7077 which is blocking the RC including maplibre traces 🙏

@gvwilson gvwilson added feature something new P2 needed for current cycle infrastructure build process etc. fix fixes something broken labels Aug 9, 2024
@birkskyum birkskyum force-pushed the Use-node.js-v18-and-npm-v10-in-development branch from 6eaa057 to 7775810 Compare August 9, 2024 21:24
@birkskyum
Copy link
Contributor Author

@archmoj , it's only the mathjaxfirefox 81/82 that fails after rebasing. Maybe it works with the quotes removed - i don't know because the ci didn't run my last commit.

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

I don't see last CircleCI run.
@birkskyum Please push again.
Thank you!

@birkskyum
Copy link
Contributor Author

I made a new commit now here

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 12, 2024

Karma is still struggling to start the old firefox 81/82 (2020 releases), but the latest start fine.

@birkskyum birkskyum force-pushed the Use-node.js-v18-and-npm-v10-in-development branch from 6e5dc41 to 17e0058 Compare August 12, 2024 17:09
@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 12, 2024

@archmoj , I think this is why firefox won't start - some expired key.

Screenshot 2024-08-12 at 19 14 46

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

Please resolve the conflicts or open a new PR.
Thank you!

@birkskyum birkskyum force-pushed the Use-node.js-v18-and-npm-v10-in-development branch from 17e0058 to 8776102 Compare August 12, 2024 19:59
@birkskyum birkskyum force-pushed the Use-node.js-v18-and-npm-v10-in-development branch from 8776102 to dc406be Compare August 12, 2024 19:59
@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

Please consider updating versions mentioned in https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#prerequisites as well.
Thank you!

@birkskyum
Copy link
Contributor Author

it's updated now

@archmoj
Copy link
Contributor

archmoj commented Aug 12, 2024

There is also preversion test at

"preversion": "check-node-version --node 16 --npm 8 && npm-link-check && npm ls --prod --all",

Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new fix fixes something broken infrastructure build process etc. P2 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Node 16 - it reached end-of-life 11 Sep 2023
3 participants