Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Chart2Music keyboard and sound accessibility features #6680

Open
wants to merge 81 commits into
base: master
Choose a base branch
from

Commits on Jul 21, 2023

  1. initial commit, single scatter plot

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6fb9c65 View commit details
    Browse the repository at this point in the history
  2. single scatter plot

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    87b4c5c View commit details
    Browse the repository at this point in the history
  3. options and info

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    64ae505 View commit details
    Browse the repository at this point in the history
  4. data and trace labels

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d37d24f View commit details
    Browse the repository at this point in the history
  5. false default

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d0467bb View commit details
    Browse the repository at this point in the history
  6. remove debugging prints

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3a73776 View commit details
    Browse the repository at this point in the history
  7. use index if no x provided

    Alistair-Welch committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    b4df959 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Lib requirement

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    97b608f View commit details
    Browse the repository at this point in the history
  2. layout destructuring

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6205d62 View commit details
    Browse the repository at this point in the history
  3. layout defaults

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    7e40cde View commit details
    Browse the repository at this point in the history
  4. destructure trace

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6d9185b View commit details
    Browse the repository at this point in the history
  5. test sourcetype module

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    935cf54 View commit details
    Browse the repository at this point in the history
  6. remove sourcetype

    Alistair-Welch committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    44deae2 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. into es5

    Alistair-Welch committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c38ab67 View commit details
    Browse the repository at this point in the history
  2. include mjs files

    Alistair-Welch committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c6a27be View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. transpile accessibility

    Alistair-Welch committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    cac174c View commit details
    Browse the repository at this point in the history
  2. accessibility in config

    Alistair-Welch committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    159ca1b View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    7467a47 View commit details
    Browse the repository at this point in the history
  2. Remove special rules from webpack.config:

    I agree with the contributor's choice of dialetc over plotly's default.
    
    However, I think adding piece-meal rules to change how stuff is built
    will ultimately make it more complicated to refactor, maintain, and read
    in the future.
    
    The current dialect of javascript (enforced primarily by the linter at
    least in the pull-request stage), is limiting and inconvenient.
    Migrating to a more modern javascript, I believe, requires a broader
    strategy.
    ayjayt committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    08b820b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Configuration menu
    Copy the full SHA
    41b0fb9 View commit details
    Browse the repository at this point in the history
  2. Lint

    ayjayt committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    94e25c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    61ea8ce View commit details
    Browse the repository at this point in the history
  2. Remove a console.log

    ayjayt committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c9a0b91 View commit details
    Browse the repository at this point in the history
  3. Limit chunks to 1

    ayjayt committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    cc92639 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7baa0d3 View commit details
    Browse the repository at this point in the history
  5. Rewrite accessibility in es5

    ayjayt committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3127dee View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1 from geopozo/pikul-music-import-promise

    Update to your pull-request for making es5/require work.
    aliwelchoo authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    2429e55 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    00572e8 View commit details
    Browse the repository at this point in the history
  8. update plot-schema diff

    ayjayt committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    30f4e11 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    247b301 View commit details
    Browse the repository at this point in the history
  2. Add config so dev can place closed captions:

    Adding a closed caption div to plotly interefered with plotly's
    management of it.
    
    We now start by default outside of the generated plotly divs.
    
    But we add options to users can a) generate it with any id/class.
    
    Or specify that it already exists and use an existing element by id.
    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d08adfb View commit details
    Browse the repository at this point in the history
  3. Merge branch 'chart2music' of https://github.com/aliwelchoo/plotly.js

    …into pikul-music-import-promise
    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    dbce5da View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e1f9563 View commit details
    Browse the repository at this point in the history
  5. Lint

    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3f4ab54 View commit details
    Browse the repository at this point in the history
  6. Skip empty trace data in accessibility.enable:

    Passing named empty arrays to chart2music makes it angry during
    validation.
    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    92d97b7 View commit details
    Browse the repository at this point in the history
  7. update plot-schema diff

    ayjayt committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    6b2dcc9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Modify how accessibility treats config vars:

    accessibility.js takes configuration variables from `plot_config.js`, modifies
    them, and passes them directly to `chart2music`.
    
    The problem is that assigning an object to a new variable doesn't copy
    it, so any change to that variable also changes the original object.
    
    Plotly uses changes (or lack thereof) in the config variables to decide if it can
    shortcut certain redraw steps. It cannot if config variables change. So
    if `accessibility.js` is run on every redraw, the config variables will look
    different (even if they are not), and plotly will always take the long
    way around during its rerendering.
    
    That being said, this solution here may need more thought. Questions
    like: when _should_ chart2music ask plotly to do a full redraw? Should
    it ever? Would it do that by changing a config it has access to? Will it
    ever change plotly config variables frequently.
    ayjayt committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b5bb517 View commit details
    Browse the repository at this point in the history
  2. Remove jasmine ftest focus

    ayjayt committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    25ca44a View commit details
    Browse the repository at this point in the history
  3. Run schema plot diff

    ayjayt committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    7328324 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00b2750 View commit details
    Browse the repository at this point in the history
  5. Set c2music default to not make its caption div:

    I can't think of instance where
    
    1) the caption div wouldn't be specified by the user
    2) would maybe do some really fancy interaction w/ the graph
    3) be completely invisible because its meant to be read outloud anyway
    
    Either way, the generation strategy needs work.
    
    * Tests now create their closed caption div
    ayjayt committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b04bb17 View commit details
    Browse the repository at this point in the history
  6. update plot-scheme diff

    ayjayt committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d4bd71b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    af2ff80 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Merge pull request #2 from geopozo/pikul-music-import-promise

    FIX and Add options to chart2music plotly integration
    aliwelchoo authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    80b4cf3 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    ee99f35 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    3841640 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    d84d108 View commit details
    Browse the repository at this point in the history
  2. Refactor accessibility/c2m:

    1) Since accessibility.js will support multiple accessibility libraries,
       there is now a C2M library that contains the API for initializing C2M
       to plotly charts.
    2) The initialization process is split into it's various phases.
    3) Trace types now have specific codecs to map plotly-C2M. See the
       README in each file.
    4) xy-scatter codec was refactored a bit to not assume the x-y is
       domain-range.
    5) All config variables are now copied from defaults so C2M doesn't mess
       with plotly's config obect.
    ayjayt committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0c43407 View commit details
    Browse the repository at this point in the history
  3. Lint

    ayjayt committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4c75035 View commit details
    Browse the repository at this point in the history
  4. Fix import path

    ayjayt committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3c49ed6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f7be666 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Configuration menu
    Copy the full SHA
    4a260af View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    f67c513 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    41baab9 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge with master

    marthacryan committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    26754b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Configuration menu
    Copy the full SHA
    ed18907 View commit details
    Browse the repository at this point in the history
  2. Spelling

    marthacryan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1e4bcef View commit details
    Browse the repository at this point in the history
  3. fix directory name

    marthacryan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2c1abf4 View commit details
    Browse the repository at this point in the history
  4. Reset package-lock

    marthacryan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    614fb8b View commit details
    Browse the repository at this point in the history
  5. Update package-lock.json

    marthacryan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5f5e599 View commit details
    Browse the repository at this point in the history
  6. Reset tests

    marthacryan committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    fe9736e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    59ad5c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    d18c584 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    043d408 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    129eb3b View commit details
    Browse the repository at this point in the history
  4. Add baseline for new mock

    marthacryan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    acc8517 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c5ad240 View commit details
    Browse the repository at this point in the history
  6. Update baseline

    marthacryan committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0113d90 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    771029e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    bfbbbf1 View commit details
    Browse the repository at this point in the history
  2. Revert "Code readability improvements"

    This reverts commit 129eb3b.
    marthacryan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cadfd7f View commit details
    Browse the repository at this point in the history
  3. Fix syntax

    marthacryan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    56e582d View commit details
    Browse the repository at this point in the history
  4. remove comment

    marthacryan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8e55f98 View commit details
    Browse the repository at this point in the history
  5. Remove todo

    marthacryan committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    86d75d8 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Schema update

    marthacryan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    15671b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    057e067 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44f7ad3 View commit details
    Browse the repository at this point in the history
  4. Fix filepaths

    marthacryan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8e3b62b View commit details
    Browse the repository at this point in the history
  5. Code cleanup

    marthacryan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    aed1e02 View commit details
    Browse the repository at this point in the history
  6. Code cleanup

    marthacryan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    1777fba View commit details
    Browse the repository at this point in the history
  7. Code cleanup

    marthacryan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3a0384f View commit details
    Browse the repository at this point in the history