Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default half span of latitude #5033

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Fix default half span of latitude #5033

merged 1 commit into from
Jul 30, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 30, 2020

The range for longitude is 360 degrees. And for latitude it is 180 degrees.
So the half span default for latitude should be set to 90.
This is also blocking bumping d3-geo in respect to #424.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jul 30, 2020
alexcjohnson
alexcjohnson approved these changes Jul 30, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 0de3bf3 into master Jul 30, 2020
@archmoj archmoj deleted the fix-max-latitude-span-dflt branch July 30, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson