Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add candlestick support #2053

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

moutikabdessabour
Copy link
Contributor

@moutikabdessabour moutikabdessabour commented Oct 23, 2021

  • change news.md

NEWS.md Outdated Show resolved Hide resolved
@@ -0,0 +1,37 @@
if(require(tidyquant)){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use testthat::skip_if_not_installed() instead

Comment on lines +625 to +633
#' @export
to_basic.GeomRectCS <- function(data, ...){
to_basic.GeomRect(data, ...)
}
#' @export
to_basic.GeomLinerangeBC <- function(data, ...){
data[, c("xend", "y", "yend")] <- data[, c("x", "ymin", "ymax")]
to_basic.GeomSegment(data, ...)
}
Copy link
Collaborator

@cpsievert cpsievert Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do more to come up with better hovertext (the tooltip info is basically useless at this point).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into this

Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments/suggestions

moutikabdessabour and others added 2 commits November 2, 2021 12:12
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants