Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subplot(): fix ystart/yend double flip #1499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alyst
Copy link
Contributor

@alyst alyst commented Mar 20, 2019

This is a small cleanup to the subplot() grid layout logic: when defining the new domains of Y axis, get_domains() sets the new ystart > yend, but later in subplot()/reposition() the ystart and yend are reversed to do the proper transformation.
With the fix the logic of handling both X and Y axes is unified: *start is always less than *end, the axis domain is always from *start to *end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant