Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change selenium version to avoid deprecation warnings #2964

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

AugustoMagalhaes
Copy link

Some tools depending on Dash have been facing the same deprecation warning from issue #2590, which can be solved by modifying the selenium upper range version to 4.6.1, as found in https://stackoverflow.com/questions/75382508/deprecationwarning-httpresponse-getheader-is-deprecated-and-will-be-removed-i. I've tested the change in python versions 3.8.x, 3.9.x, 3.10.x, 3.11.x and 3.12.x and no problem has been found.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Change selenium version range
    • Run tests from python 3.8 to 3.12 to check if this change could break the tests
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@gvwilson gvwilson added infrastructure build process etc. P2 needed for current cycle fix fixes something broken community community contribution labels Aug 26, 2024
@AugustoMagalhaes AugustoMagalhaes changed the title Change selenium version to avoid depecration warnings Change selenium version to avoid deprecation warnings Aug 26, 2024
@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 3, 2024

There is a few failures that are related to our tests rather than the dash[testing] api.
Here we have a removal: AttributeError: 'WebElement' object has no attribute 'find_element_by_tag_name' for this test: - tests/integration/callbacks/test_multiple_callbacks.py:585 test_cbmt013_chained_callback_should_be_blocked that needs to be changed.
test_duo001_wait_for_text_error and test_duo002_wait_for_text_value test the testing api, probably needs to be adapted too.
For the failures in dcc tests, I think it's the dash_duo methods that is failing and may need to be fixed: click_at_coord_fractions

@AugustoMagalhaes
Copy link
Author

There is a few failures that are related to our tests rather than the dash[testing] api. Here we have a removal: AttributeError: 'WebElement' object has no attribute 'find_element_by_tag_name' for this test: - tests/integration/callbacks/test_multiple_callbacks.py:585 test_cbmt013_chained_callback_should_be_blocked that needs to be changed. test_duo001_wait_for_text_error and test_duo002_wait_for_text_value test the testing api, probably needs to be adapted too. For the failures in dcc tests, I think it's the dash_duo methods that is failing and may need to be fixed: click_at_coord_fractions

Thanks for the feedback, T4rk1n. So just to confirm: I should work on the dash_duo methods for dcc failing tests or should I also work on fixing the other mentioned ones?

@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 4, 2024

So just to confirm: I should work on the dash_duo methods for dcc failing tests or should I also work on fixing the other mentioned ones?

Yes they both need fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution fix fixes something broken infrastructure build process etc. P2 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants