Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for allowing request_refresh_jwt hooks with json response #2942

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

yzcheung
Copy link

@yzcheung yzcheung commented Aug 6, 2024

Contributor Checklist
I have broken down my PR scope into the following TODO tasks

Implement request_refresh_jwt hooks
Allow JSON format responses
I have run the tests locally and they passed. (refer to testing section in contributing)

I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

@gvwilson gvwilson self-assigned this Aug 7, 2024
@gvwilson
Copy link
Contributor

gvwilson commented Aug 7, 2024

hi @yzcheung - thanks very much for your PR. We're currently trying to figure out which bits of authentication should go in dash, which should go in dash-auth, and which we should reserve for our enterprise offering - I've assigned this to myself so I don't lose track of it, and I hope to have some answers for you in a couple or three weeks. cheers - @gvwilson

@yzcheung
Copy link
Author

yzcheung commented Aug 7, 2024

hi @yzcheung - thanks very much for your PR. We're currently trying to figure out which bits of authentication should go in dash, which should go in dash-auth, and which we should reserve for our enterprise offering - I've assigned this to myself so I don't lose track of it, and I hope to have some answers for you in a couple or three weeks. cheers - @gvwilson

Cool, thanks for the update. Looking forward to hearing back soon!

@gvwilson gvwilson added feature something new P2 needed for current cycle community community contribution labels Aug 13, 2024
@gvwilson gvwilson removed their assignment Aug 13, 2024
@gvwilson gvwilson self-assigned this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants