fix unexpected behaviour of Dropdown #2933
Open
+43
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcc.Dropdown has inconsistent layout flow compared to other common input components. The layout bug is normalised with CSS style display set to inline-block.
AfonsoFaleiro
requested review from
alexcjohnson,
T4rk1n and
ndrezn
as code owners
gvwilson
changed the title
T4rk1n
reviewed
Sep 3, 2024
| @@ -1,6 +1,7 @@ | |||
| import PropTypes from 'prop-types'; | |||
| import React, {Component, lazy, Suspense} from 'react'; | |||
| import dropdown from '../utils/LazyLoader/dropdown'; | |||
| import './css/Dropdown.css'; | |||
There was a problem hiding this comment.
This file is already imported here:
T4rk1n
reviewed
Sep 3, 2024
| className={`dash-dropdown ${className || ''}`} | ||
| styles={{ | ||
| control: (provided) => ({ | ||
| ...provided, |
There was a problem hiding this comment.
Provided should be at the end to possibly overload the defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2653
Issue:
dcc.Dropdown has inconsistent layout flow
compared to other common input components.
Changes:
render() of dcc.Dropdown and Dropdown.css styled with display set to inline-block.
Contributor Checklist