Explain versioning system #294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrezn
commented
Apr 25, 2024
tests/test_versioning.py
Outdated
| ag_version = parse(dag.grid_version) | ||
| dash_ag_version = parse(dag.__version__) | ||
|
|
||
| assert ( |
There was a problem hiding this comment.
Hm I guess we only would want to run this test when the version is bumped...
There was a problem hiding this comment.
That's why it needs to be a test before dist and not on github
BSd3v
reviewed
Apr 30, 2024
tests/test_versioning.py
Outdated
There was a problem hiding this comment.
Does this even need to be a test?
I think you should just run the script by itself and not muddy up the tests/ path?
If a new contributor wanted to run tests and bumped their version this would fail with pytest
There was a problem hiding this comment.
hm yeah, that's a good idea. Let me think about this for a minute. It might make sense to move it out, or to have a tests config file to exclude it unless specified..
gvwilson
added
documentation
…fter the build to make sure that the package for the test is the currently coded package. Otherwise you can fail and pass errantly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explains how versioning works, and adds a test to ensure we actually follow the system!