Improve performance of combineMorphs #1553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloning many morph attributes takes many CPU resources
… is 1.0, we can use the original as-is
0b5vr
commented
Dec 10, 2024
| // prevent cloning morph attributes | ||
| const originalMorphAttributes = mesh.geometry.morphAttributes; | ||
| mesh.geometry.morphAttributes = {}; | ||
|
|
||
| const geometry = mesh.geometry.clone(); |
There was a problem hiding this comment.
Here, cloning takes many CPU resources if the model has many morph attributes. the L121 prevents cloning morph attributes.
0b5vr
commented
Dec 10, 2024
Comment on lines
+27
to
+33
| // if there is only one morph target and the weight is 1.0, we can use the original as-is | ||
| if (binds.size === 1) { | ||
| const bind = binds.values().next().value!; | ||
| if (bind.weight === 1.0) { | ||
| return positionAttributes[bind.index]; | ||
| } | ||
| } |
There was a problem hiding this comment.
Pretty straightforward improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the initial stutter when combineMorphs is used after the loading.