deps: Bump Three.js to r171 #1548
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm yet to neither check the behavior nor see the changelog The entrypoint change mrdoob/three.js#29404 might be relevant to us https://github.com/mrdoob/three.js/releases/tag/r171
0b5vr
force-pushed
the
bump-three-r171
branch
from
95aef63 to
63e146e
Compare
|
mrdoob/three.js#29644 moves the entrypoint of TSL related functions from r171In r171, the user have to add a line to importmap that resolves <script type="importmap">
{
"imports": {
"three": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.webgpu.js",
"three/webgpu": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.webgpu.js",
+ "three/tsl": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.tsl.js",
"three/addons/": "https://cdn.jsdelivr.net/npm/[email protected]/examples/jsm/",
...
}
}
</script>With a bundler, I believe the user don't have to make any changes to the app code base. pre-r171Same as r171, the user have to resolve the <script type="importmap">
{
"imports": {
"three": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.webgpu.js",
"three/webgpu": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.webgpu.js",
+ "three/tsl": "https://cdn.jsdelivr.net/npm/[email protected]/build/three.webgpu.js",
"three/addons/": "https://cdn.jsdelivr.net/npm/[email protected]/examples/jsm/",
...
}
}
</script>With a bundler, the user must resolve If the user is using Vite, it can be achieved by using export default defineConfig({
resolve: {
alias: {
'three/tsl': 'three/webgpu',
},
},
// ...
}) |
mrdoob/three.js#29644 moves TSL functions into `three/tsl` The users have to modify the import map or bundler config because of this change See: #1548 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Three.js to r171.
I'm yet to neither check the behavior nor see the changelog
The entrypoint change mrdoob/three.js#29404 might be relevant to us
https://github.com/mrdoob/three.js/releases/tag/r171