Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: skip execution when build query for VIEW in I_S (#58203) #58231

Merged
merged 3 commits into from
Dec 13, 2024
Merged

executor: skip execution when build query for VIEW in I_S (#58203) #58231

merged 3 commits into from
Dec 13, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58184

Problem Summary:

What changed and how does it work?

use PlanBuilderOptNoExecution to skip unnecessary execution. This should be the same behaviour with SHOW COLUMNS

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 13, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
fix bazel
8e10a79 
Signed-off-by: lance6716 <[email protected]>
@lance6716
fix fmt
66a878c 
Signed-off-by: lance6716 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
Benjamin2037
Benjamin2037 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5-20241213-v6.5.11@3f20732). Learn more about missing BASE report.

Additional details and impacted files 
@@                        Coverage Diff                        @@
##             release-6.5-20241213-v6.5.11     #58231   +/-   ##
=================================================================
  Coverage                                ?   73.6185%           
=================================================================
  Files                                   ?       1097           
  Lines                                   ?     352926           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     259819           
  Misses                                  ?      76393           
  Partials                                ?      16714

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 13, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-13 02:03:48.654056524 +0000 UTC m=+576818.742859063: ☑️ agreed by Benjamin2037.
  • 2024-12-13 02:10:23.881600796 +0000 UTC m=+577213.970403339: ☑️ agreed by tangenta.

tangenta
tangenta reviewed Dec 13, 2024
View reviewed changes
tools/check/check-bazel-prepare.sh
@@ -19,6 +19,7 @@
# -o pipefail: sets the exit code of a pipeline to that of the rightmost command to exit with a non-zero status,
# or to zero if all commands of the pipeline exit successfully.
set -euo pipefail
rm -rf /home/jenkins/.cache/bazel/_bazel_jenkins/install/a09dbb90c658248f08f9aa0eba11997d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel building system leaves an invalid cache in our CI, need to manually delete it. Will send you details in our IM

@tangenta
Copy link
Contributor

/hold

I have a comment, but feel free to unhold this

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5327b6d into pingcap:release-6.5-20241213-v6.5.11 Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @tangenta @Benjamin2037