-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: cancel the hearbeat timeout job after disable the TTL #57452
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57452 +/- ##
================================================
+ Coverage 72.8400% 73.6332% +0.7931%
================================================
Files 1672 1672
Lines 462663 463796 +1133
================================================
+ Hits 337004 341508 +4504
+ Misses 104862 101525 -3337
+ Partials 20797 20763 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yang Keao <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57404
Problem Summary:
If a job's hearbeat timeout, it cannot be cancelled after disabling the TTL job.
What changed and how does it work?
Move the logic of locking the heartbeat timeout job above the logic of cancelling jobs.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.