Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix cannot binding for deleting multi table with alias (#57255) #57421

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57255

What problem does this PR solve?

Issue Number: close #56726

Problem Summary:

What changed and how does it work?

delete tt1 from t1 tt1,(select max(id) id from t2)tt2 where tt1.id<=tt2.id
delete tt1 will be transfer to delete current_database.t1 in default when to deal with the statsment in the create binding.
because tt1 cannot be used as alias in delete statement.
so we have to set tt1 as alias by aliasChecker.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix cannot binding for deleting multi table with alias

修复无法为带别名的多表删除进行 binding 的问题

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 15, 2024
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 04:21:33.285931865 +0000 UTC m=+848455.476800854: ☑️ agreed by fixdb.
  • 2024-12-02 03:05:46.492797556 +0000 UTC m=+1037734.112452072: ☑️ agreed by hawkingrei.

@hawkingrei hawkingrei requested a review from tangenta December 2, 2024 03:09
Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@af934cf). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #57421   +/-   ##
================================================
  Coverage               ?   71.2063%           
================================================
  Files                  ?       1467           
  Lines                  ?     423389           
  Branches               ?          0           
================================================
  Hits                   ?     301480           
  Misses                 ?     101415           
  Partials               ?      20494           
Flag Coverage Δ
unit 71.2063% <94.5945%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3256% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 68b29d4 into pingcap:release-8.1 Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants