-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix cannot binding for deleting multi table with alias (#57255) #57421
planner: fix cannot binding for deleting multi table with alias (#57255) #57421
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Co-authored-by: tangenta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, hawkingrei, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #57421 +/- ##
================================================
Coverage ? 71.2063%
================================================
Files ? 1467
Lines ? 423389
Branches ? 0
================================================
Hits ? 301480
Misses ? 101415
Partials ? 20494
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #57255
What problem does this PR solve?
Issue Number: close #56726
Problem Summary:
What changed and how does it work?
delete tt1 from t1 tt1,(select max(id) id from t2)tt2 where tt1.id<=tt2.id
delete tt1
will be transfer todelete current_database.t1
in default when to deal with the statsment in thecreate binding
.because
tt1
cannot be used as alias in delete statement.so we have to set
tt1
as alias by aliasChecker.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.