statistics: wrong NDV when to merge global stats with index #57269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
AilinKid
approved these changes
Nov 11, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, time-and-fate The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #57269 +/- ##
================================================
Coverage ? 73.6237%
================================================
Files ? 1097
Lines ? 352943
Branches ? 0
================================================
Hits ? 259850
Misses ? 76370
Partials ? 16723 |
hawkingrei
commented
Nov 11, 2024
| @@ -1289,7 +1289,7 @@ func (h *Handle) indexStatsFromStorage(reader *statsReader, row chunk.Row, table | |||
| if histID != idxInfo.ID { | |||
| continue | |||
| } | |||
| if idx == nil || idx.LastUpdateVersion < histVer { | |||
There was a problem hiding this comment.
This logic is the same as column.
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
hawkingrei
added a commit
to hawkingrei/tidb
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #57264
Problem Summary:
What changed and how does it work?
when we read stats for merge global stats, we forget to force to load fm skretch. so it will lead wrong NDV.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.