executor: fix data inconsistency after load data ... replace into ... | tidb-test=e5f82b826aeb7e912c2d4dc36389960daac36d96
#56521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
fzzf678
changed the title
load data ... replace into ...load data ... replace into ... | tidb-test=release-6.5.10 plugin=release-6.5
fzzf678
changed the title
load data ... replace into ... | tidb-test=release-6.5.10 plugin=release-6.5 load data ... replace into ... | tidb-test=release-6.5.10
|
/ok-to-test |
fzzf678
changed the title
load data ... replace into ... | tidb-test=release-6.5.10load data ... replace into ... | tidb-test=release-6.5
|
/retest |
fzzf678
changed the title
load data ... replace into ... | tidb-test=release-6.5load data ... replace into ... | tidb-test=release-6.5.10
|
/retest |
fzzf678
changed the title
load data ... replace into ... | tidb-test=release-6.5.10load data ... replace into ... | tidb-test=c1ec4c1217f86e83e4c07da09ef909e3af84ee7e
|
/retest |
fzzf678
changed the title
load data ... replace into ... | tidb-test=c1ec4c1217f86e83e4c07da09ef909e3af84ee7eload data ... replace into ... | tidb-test=e5f82b826aeb7e912c2d4dc36389960daac36d96
|
/retest |
1 similar comment
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20241009-v6.5.10 #56521 +/- ##
=================================================================
Coverage ? 73.6313%
=================================================================
Files ? 1096
Lines ? 352259
Branches ? 0
=================================================================
Hits ? 259373
Misses ? 76209
Partials ? 16677 |
CbcWestwolf
approved these changes
Oct 10, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
wjhuang2016
approved these changes
Oct 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
lance6716
reviewed
Oct 10, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| if skip { | ||
| break |
There was a problem hiding this comment.
break will skip removeRow for rest r.uniqueKeys. I'm not sure if this is expected. Please find some execution reviewers to check
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
ti-chi-bot
bot
merged commit 3635e94
into
pingcap:release-6.5-20241009-v6.5.10
10 checks passed
|
/unhold I see this is the same logic in master branch |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an cherry-pick of #56415
What problem does this PR solve?
Issue Number: close #56408
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.