planner: fix incompatible behaviors between prep and non-prep stateme… | tidb-test=pr/2145 #46739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts when converting date/time values (pingcap#42443) close pingcap#42439
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/S
hawkingrei
approved these changes
Sep 7, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/retest |
qw4990
approved these changes
Sep 7, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
6 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
YangKeao
changed the title
|
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20230425-v6.5.2 #46739 +/- ##
================================================================
Coverage ? 73.4045%
================================================================
Files ? 1079
Lines ? 345991
Branches ? 0
================================================================
Hits ? 253973
Misses ? 75586
Partials ? 16432 |
ti-chi-bot
bot
merged commit e315400
into
pingcap:release-6.5-20230425-v6.5.2
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an manual cherry-pick of #42443
What problem does this PR solve?
Issue Number: close #42439
Problem Summary: planner: fix incompatible behaviors between prep and non-prep statements when converting date/time values
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.