Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoid_service: fix the result of NextGlobalAutoID() for AUTO_ID_CACHE=1 (#46550) #46565

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46550

What problem does this PR solve?

Issue Number: close #46545

Problem Summary:

What is changed and how it works?

After #39041 the row id and auto increment id use different key.
Here IncrementID should be used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Follow the step in issue #46545
It's not easy to integration test for this, since the bug need a tidb restart to trigger.
After the autoid service initialized, the cached value is used and the code logic does not go the buggy line.

https://github.com/pingcap/tidb/pull/46550/files#diff-617839a099f419c84781f44a2286d763780a446a701eac0a440c7c579378706cR457-R462

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@djshow832
Copy link
Contributor

Close it because it's minor.

@djshow832 djshow832 closed this Oct 7, 2023
@tiancaiamao tiancaiamao reopened this Nov 29, 2023
@tiancaiamao
Copy link
Contributor

Reopen, need this to pass the 6.5.6 br CI integration test

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46565   +/-   ##
================================================
  Coverage               ?   73.6414%           
================================================
  Files                  ?       1087           
  Lines                  ?     349427           
  Branches               ?          0           
================================================
  Hits                   ?     257323           
  Misses                 ?      75594           
  Partials               ?      16510           

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 29, 2023
Copy link

ti-chi-bot bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiancaiamao, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2023
Copy link

ti-chi-bot bot commented Nov 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-29 11:02:52.351498123 +0000 UTC m=+1007001.016724319: ☑️ agreed by YangKeao.
  • 2023-11-29 11:41:28.871810542 +0000 UTC m=+1009317.537036738: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit e5ee37e into pingcap:release-6.5 Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants