Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] pr for test #46369

Closed
wants to merge 30 commits into from
Closed

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520 crazycs520 requested a review from a team as a code owner August 23, 2023 14:02
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 23, 2023
@crazycs520
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 23, 2023
@tiprow
Copy link

tiprow bot commented Aug 23, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Aug 23, 2023

@crazycs520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Aug 23, 2023

@crazycs520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfzjywxk cfzjywxk force-pushed the tidb-6.5-with-kv-timeout-feature branch from 19afd53 to 5044f8f Compare August 29, 2023 00:41
@cfzjywxk
Copy link
Contributor

/retest

2 similar comments
@cfzjywxk
Copy link
Contributor

/retest

@crazycs520
Copy link
Contributor Author

/retest

@cfzjywxk
Copy link
Contributor

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 29, 2023

@cfzjywxk: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes are missing coverage. Please review.

Please upload report for BASE (release-6.5@df1106e). Learn more about missing BASE report.

Current head 85d9fc8 differs from pull request most recent head a62856d

Please upload reports for the commit a62856d to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46369   +/-   ##
================================================
  Coverage               ?   73.6501%           
================================================
  Files                  ?       1084           
  Lines                  ?     348146           
  Branches               ?          0           
================================================
  Hits                   ?     256410           
  Misses                 ?      75272           
  Partials               ?      16464           

crazycs520 and others added 9 commits September 1, 2023 21:54
* kv request: configurable KV Timeout (#45601)

close #45380

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

* refine code

Signed-off-by: crazycs520 <[email protected]>

* make bazel_prepare

Signed-off-by: crazycs520 <[email protected]>

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: Chen Ding <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: cfzjywxk <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@cfzjywxk cfzjywxk force-pushed the tidb-6.5-with-kv-timeout-feature branch from 85d9fc8 to cb36e18 Compare September 1, 2023 14:02
@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@crazycs520: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

crazycs520 and others added 17 commits September 15, 2023 14:18
Signed-off-by: crazycs520 <[email protected]>
) (#47003)

* client-go: attach request source with retry info for coprocessor (#46509) (#46706)

close #46514

* restore bazelversiong

Signed-off-by: you06 <[email protected]>

* remove unused field

Signed-off-by: you06 <[email protected]>

* update client-go

Signed-off-by: you06 <[email protected]>

---------

Signed-off-by: you06 <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
* add backoff and region error check for GetMvccByEncodedKey API

Signed-off-by: crazycs520 <[email protected]>

* add test

Signed-off-by: crazycs520 <[email protected]>

* refine

Signed-off-by: crazycs520 <[email protected]>

* refine test

Signed-off-by: crazycs520 <[email protected]>

* update client-go

Signed-off-by: crazycs520 <[email protected]>

* make bazel_prepare

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: crazycs520 <[email protected]>
* use kv timeout feature for schema load operation

* add lease/10
…48282)

* add resolve lock logic for mvcc get key loading schema diff

* adstract a constant
* log expensive scan query in slow log

* add lint comment

* increasing ratio default value to 100

Signed-off-by: cfzjywxk <[email protected]>

* disable recording internal queries in slow logs

* unify the processed keys first

* format

* add inefficient scan num threshold

* add missing config

* remove debug code

* log name

* change name

* change num default value to 100k

* add comment for field

* format comments

---------

Signed-off-by: cfzjywxk <[email protected]>
@wuhuizuo wuhuizuo marked this pull request as draft February 6, 2024 08:48
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024
* sessionctx: add sysvar to control exp feats of replica selector

Signed-off-by: zyguan <[email protected]>

* *: add rpc error stats and refine log (#52810)

Signed-off-by: crazycs520 <[email protected]>

* store: refine coprocessor error log (#52729)

Signed-off-by: crazycs520 <[email protected]>

* *: improve log about stale-read query (#52494)

Signed-off-by: crazycs520 <[email protected]>

* *: refine tikv/client-go log to print context information(such as conn id) as much as possible (#45559)

Signed-off-by: crazycs520 <[email protected]>

* add leader peer id log

Signed-off-by: crazycs520 <[email protected]>

* update log

Signed-off-by: crazycs520 <[email protected]>

* executor: fix issue that some query execution stats was omitted when execution was interrupted (#51787)

close #51660

Signed-off-by: crazycs520 <[email protected]>

* update go.mod

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: zyguan <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Co-authored-by: zyguan <[email protected]>
Copy link

ti-chi-bot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from crazycs520, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crazycs520
Copy link
Contributor Author

/retest-required

@crazycs520 crazycs520 marked this pull request as ready for review May 27, 2024 05:54
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
…a version gap (#53445) (#53562)

* infoschema: fix issue of information schema cache miss cause by schema version gap (#53445)

close #53428

Signed-off-by: crazycs520 <[email protected]>
…rrectly marked as unreachable when the store restarts with label changed (#55084)

* *: update tikv/client-go for fix issue that store's liveness may incorrectly marked as unreachable when the store restarts with label changed

Signed-off-by: crazycs520 <[email protected]>

* make bazel_prepare

Signed-off-by: crazycs520 <[email protected]>

---------

Signed-off-by: crazycs520 <[email protected]>
Copy link

ti-chi-bot bot commented Jul 31, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link

ti-chi-bot bot commented Jul 31, 2024

@crazycs520: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 081edc7 link true /test check-dev2
idc-jenkins-ci-tidb/build 081edc7 link true /test build
idc-jenkins-ci-tidb/mysql-test 081edc7 link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 081edc7 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 081edc7 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crazycs520 crazycs520 closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved do-not-merge/invalid-title needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants