Skip to content

Commit

Permalink
chore: fix node version to v18.18.0 (#14)
Browse files Browse the repository at this point in the history
* doc: edit README

* refactor: move email unicity check in register to event use case

* refactor: extract email unicity check and attendee/registration insertion

* refactor: create an email already registered error

* chore: update packages

* chore: move packages in devDependencies

* refactor: delete empty index.ts

* chore: fix node version to 20.7.0

* chore: use last Node LTS version

* ci: use version in .node-version file
  • Loading branch information
dm0reau authored Sep 28, 2023
1 parent 2c3d923 commit f7d8f54
Show file tree
Hide file tree
Showing 13 changed files with 731 additions and 293 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/quality-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 20
node-version-file: ".node-version"
cache: "npm"
- run: npm install
- run: npm run format:check
Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v18.18.0
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
10 changes: 4 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@ npm install
docker compose up
```

À noter qu'il est nécessaire de lancer ces commandes à chaque fois qu'on pull de nouvelles migrations (dossier `migrations`) ou de nouveaux seeds (dossier `seeds`).
Ensuite, les services web suivants deviennent accessibles :

```bash
npm i -g knex # À faire si le CLI knex n'est pas installé en local
knex migrate:up
knex seed:run
```
- Le front [NextJS](https://nextjs.org/docs) sur http://localhost:3000
- L'administrateur de base de données [Adminer](https://www.adminer.org/) sur http://localhost:8080
- L'intercepteur d'emails [Mailcatcher](https://mailcatcher.me/) sur http://localhost:1080
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
services:
web:
image: node:20
image: node:18.18.0
restart: always
working_dir: /app
volumes:
Expand All @@ -26,7 +26,7 @@ services:
ports:
- "127.0.0.1:5432:5432"
db-setup:
image: node:20
image: node:18.18.0
working_dir: /app
volumes:
- .:/app
Expand Down
Empty file removed index.ts
Empty file.
Loading

0 comments on commit f7d8f54

Please sign in to comment.