Added option to specify the element that is appended #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of append only the "a" elements inside de toolbar-items, append the "nav" element inside the toolbar-items.
You can decide if the toolbar will handle the click (triggering the event) or not, and follow the link in the <a> element
- Show toolbar on focus (for inputs) - Hide all tooltips when a new one is shown - Option to decide if you want to show the toolbar on click
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of append only the "a" elements inside de toolbar-items, I've added an option to append any element inside the toolbar-items. The new option is "elementToAppend".
This change works with the old code, because by default the element appended is "a".