Check sensor connection thread validity before joining #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samahu
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
This makes sense, it is weird that this problem was never triggered during my testing.
I think we should increment the version number in package.xml to 0.13.3 for tracking and optionally add the following statement to the CHANGELOG.rst file:
[BUGFIX] Segmentation fault if sensor is unpowered on start-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
#410
Summary of Changes
Perform a check for a nullptr on unique pointer type before usage, that otherwise has the capacity to be null when not initialised due to the sensor not being powered on start-up.
Validation
Tested on-site