Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the default value of the bag file param in replay to an empty string #404

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Set the default value of the bag file param in replay to an empty string #404

merged 1 commit into from
Nov 20, 2024

Conversation

nkhedekar
Copy link
Contributor

@nkhedekar nkhedekar commented Nov 19, 2024 •
edited by Samahu
Loading

Related Issues & PRs

Summary of Changes

Set the default value of the bag file param in replay to an empty string so that the launch will not crash on this line:

ouster-ros/launch/replay.launch

Line 121 in 1dbdbb4

<arg name="_use_bag_file_name" value="$(eval not (bag_file == ''))"/>

Validation

Run roslaunch ouster_ros replay.launch and see that it does not crash

@Samahu Samahu self-requested a review November 20, 2024 00:57
Samahu
Samahu approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Samahu Samahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

@Samahu Samahu merged commit c6f66d2 into ouster-lidar:master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samahu Samahu Samahu approved these changes

Assignees

@nkhedekar nkhedekar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replay.launch crashes if you do not provide a value for the bag_file arg
2 participants
@nkhedekar @Samahu