Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Warning message whenever a terms is created within a same … #1696

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

mavenzer
Copy link
Contributor

@mavenzer mavenzer commented Aug 2, 2024

This is the MR #1695 for the issue which we raised. Attaching the screenshot for the couple of terms tested from our end with the warning/error message.

term-duplication

@mavenzer mavenzer requested a review from a team as a code owner August 2, 2024 16:08
Copy link
Contributor

@AndreyNenashev AndreyNenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavenzer There is something wrong happened with margins.

@mavenzer
Copy link
Contributor Author

@AndreyNenashev I will look into it.

Copy link

sonarcloud bot commented Aug 17, 2024

@mavenzer
Copy link
Contributor Author

@AndreyNenashev I have added the margins whenever the alert is popped up, Attaching a screenshot for reference. Please have a look and let me know if there are any issues.
v25

@AndreyNenashev AndreyNenashev merged commit 698e83a into opendatadiscovery:main Aug 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants