Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1640 Relationships details overview #1649

Merged
merged 4 commits into from
Apr 1, 2024
Merged

1640 Relationships details overview #1649

merged 4 commits into from
Apr 1, 2024

Conversation

anatolii-yemets
Copy link
Contributor

fixes #1640
entity_rel
graph_rel

@anatolii-yemets anatolii-yemets requested a review from a team as a code owner March 28, 2024 15:31
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@RamanDamayeu
Copy link
Contributor

  1. Let's replace Block of "Source" and "Target"
  2. Let's rename "Source" to "Child" and "Target" to "Parent"
  3. Naming for Column Stats in the relationships: for "Parent" is should be named "Referenced Key", for "Child" is should be named "Foreign Key"

AndreyNenashev
AndreyNenashev previously approved these changes Mar 29, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Test Results

  55 files    55 suites   2m 33s ⏱️
259 tests 259 ✔️ 0 💤 0 ❌
287 runs  287 ✔️ 0 💤 0 ❌

Results for commit ff4d039.

@anatolii-yemets
Copy link
Contributor Author

image

@anatolii-yemets
Copy link
Contributor Author

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed for 'odd-platform-ui'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@anatolii-yemets anatolii-yemets merged commit 90efc54 into main Apr 1, 2024
5 of 6 checks passed
@anatolii-yemets anatolii-yemets deleted the 1640 branch April 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamanDamayeu RamanDamayeu RamanDamayeu approved these changes

@AndreyNenashev AndreyNenashev Awaiting requested review from AndreyNenashev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DATA MODELLING. RELATIOSHIPS]. Relationships details overview
3 participants
@anatolii-yemets @RamanDamayeu @AndreyNenashev