Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input component refactoring #1441

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Input component refactoring #1441

merged 3 commits into from
Sep 27, 2023

Conversation

Leshe4ka
Copy link
Contributor

Resolve #1370

@Leshe4ka Leshe4ka added kind: enhancement Enhancement of existing feature scope: frontend Frontend task labels Sep 26, 2023
@Leshe4ka Leshe4ka requested a review from a team as a code owner September 26, 2023 08:30
@Leshe4ka Leshe4ka self-assigned this Sep 26, 2023
@github-actions

This comment has been minimized.

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

[odd-platform-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

@github-actions
Copy link

Test Results

  52 files    52 suites   1m 33s ⏱️
242 tests 242 ✔️ 0 💤 0
270 runs  270 ✔️ 0 💤 0

Results for commit ccac6cd.

@AndreyNenashev
Copy link
Contributor

@Leshe4ka Could you add simple explanation why we needed to replace/refactor old inputs and what issue we solved? It looks good for me - I just don't understand what we fix here

@Leshe4ka
Copy link
Contributor Author

@Leshe4ka Could you add simple explanation why we needed to replace/refactor old inputs and what issue we solved? It looks good for me - I just don't understand what we fix here

It's just refactoring for better use. The old version used MUI TextField under the hood, the new version is a native implementation.

@Leshe4ka Leshe4ka merged commit d4f8a9a into main Sep 27, 2023
7 checks passed
@Leshe4ka Leshe4ka deleted the input_replacement branch September 27, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement of existing feature scope: frontend Frontend task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input component replacement
2 participants