[Accton][as7535-28xb] Modify what onlpdump -x displays #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmenzel
reviewed
Aug 23, 2024
| { | ||
| int status = 0; | ||
|
|
||
| data->valid = 0; | ||
|
|
||
| if(attr->index == FPGA_VER) | ||
| data->ipmi_tx_data[0] = 0x60; |
paulmenzel
suggested changes
Aug 26, 2024
| { | ||
| int status = 0; | ||
|
|
||
| data->valid = 0; | ||
| data->ipmi_tx_data[0] = 0x60; | ||
|
|
||
| if(attr->index == FPGA_VER) |
There was a problem hiding this comment.
For consistency, the rest of the file also seems to add a space after if and else if.
acctalex
force-pushed
the
onlpd_x_fw_ver
branch
from
58ed2e8 to
85ece2a
Compare
1. Add a sysfs, minor_vsrsion, in x86-64-accton-as7535-28xb-cpld.c
2. Add a sysfs, minor_version, in x86-64-accton-as7535-28xb-fan.c
3. Add 3 sysfses, fpga_minor_version, cpu_cpld_version, and
cpu_cpld_minor_version, in x86-64-accton-as7535-28xb-sys.c
4. Modify what onlpdump -x displays.
Before modification:
CPLD Versions:
CPLD:0b
FPGA:5b
Fan CPLD:0b
After modification:
CPLD Versions:
CPU CPLD(0x65): E1.0A
Main CPLD(0x61): 0B.04
Fan CPLD(0x66): 0B.13
FPGA(0x60): 5B.16
Other Versions:
BIOS: v48.0b.03.00
ONIE: 2020.11.00.14
BMC: 0.4.00
Signed-off-by: Alex Lai <[email protected]>
acctalex
force-pushed
the
onlpd_x_fw_ver
branch
from
85ece2a to
58e8b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Accton][as7535-28xb] Modify what onlpdump -x displays
Add a sysfs, minor_vsrsion, in x86-64-accton-as7535-28xb-cpld.c
Add a sysfs, minor_version, in x86-64-accton-as7535-28xb-fan.c
Add 3 sysfses, fpga_minor_version, cpu_cpld_version, and
cpu_cpld_minor_version, in x86-64-accton-as7535-28xb-sys.c
Modify what onlpdump -x displays.
Before modification:
After modification: