Recreate PR #2861: Dockerfile cleanup #2866
Conversation
cuihtlauac
commented
Dec 12, 2024
cuihtlauac
commented
- don't cache packages to lighten the image.
Misclick from my phone, in the train... |
| RUN sudo apk -U upgrade --no-cache && sudo apk add --no-cache \ | ||
| autoconf \ | ||
| curl-dev \ | ||
| gmp-dev \ | ||
| inotify-tools \ | ||
| libev-dev \ | ||
| oniguruma-dev \ | ||
| openssl-dev |
There was a problem hiding this comment.
This is nicer to read here, but harder in the ocluster log.
There was a problem hiding this comment.
Nicer for humans, and nicer diffs.
https://docs.docker.com/build/building/best-practices/#sort-multi-line-arguments
|
There’s something I don’t get. Docker builds in cluster and GH action and fails locally on my machine: Any clues? |
Dockerfile
Outdated
|
|
||
| # Branch freeze was opam-repo HEAD at the time of commit | ||
| RUN cd opam-repository && git pull origin c45f5bab71d3589f41f9603daca5acad14df0ab0 && opam update | ||
| RUN cd ~/opam-repository && git fetch -q origin master && git reset --hard c45f5bab71d3589f41f9603daca5acad14df0ab0 && opam update |
There was a problem hiding this comment.
RUN cd ~/opam-repository && git reset --hard c45f5bab71d3589f41f9603daca5acad14df0ab0 && opam update
That commit is from June 3. Fetching here will is too early. Between two changes of this commit, we want to build the same switch and produce the same docker layer (up to system dependency changes)
There was a problem hiding this comment.
I'm not sure what you mean…
There was a problem hiding this comment.
I want Docker to cache the opam switch.
Dockerfile
Outdated
| RUN cd opam-repository && git checkout master && git pull origin master && opam update | ||
| ENV OCAMLORG_REPO_PATH opam-repository | ||
| ENV OCAMLORG_PKG_STATE_PATH package.state | ||
| RUN cd ~/opam-repository && git checkout master && opam update |
There was a problem hiding this comment.
RUN cd ~/opam-repository && git checkout master && git pull origin master && opam update
We pull here, because the opam-repo changes super frequently and we need to prefetch the ocamlorg cache with as fresh as possible data. See discussion in PR#2831
- don't cache packages to lighten the image.
Co-authored-by: Antonin Décimo <[email protected]>
Co-authored-by: Antonin Décimo <[email protected]>
