Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simplest-way-to-start example & update README #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muayKenny
Copy link

@muayKenny muayKenny commented Nov 1, 2024

Hello!

I was following the README to run the project locally and noticed a couple of outdated changes in the startup process.

Screenshot 2024-10-31 at 3 53 21 PM Screenshot 2024-10-31 at 3 53 07 PM

Changes Made:

  • index-simplest-way-to-start.html:

    • Updated to reflect that Scatterplot.ts is now a named import rather than a default export.
    • Adjusted the click_function override to properly expect a callback.
  • README Update:

    • Changed the suggested localhost port in the README to align with port 3344 in the package.json dev script.

Important

Update index-simplest-way-to-start.html for named import and callback, and correct README port number.

  • HTML Example Update:
    • In index-simplest-way-to-start.html, change Scatterplot import to named import.
    • Modify click_function to use a callback for logging datum.
  • README Update:
    • Correct localhost port from 3345 to 3344 to match package.json dev script.

This description was created by Ellipsis for 0fb0468. It will automatically update as commits are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant