feat: adds angular 18 support

[pavankjadda]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngneat/query/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[] No

Other information

Closes #179

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[pavankjadda]

Blocked by jscutlery/semver#814

[rbalet]

@pavankjadda Hi,

It seems they've fixed the error.
Can you try it out ?

bikecoders/ngx-deploy-npm#606

[pavankjadda]

@pavankjadda Hi,

It seems they've fixed the error. Can you try it out ?

bikecoders/ngx-deploy-npm#606

This jscutlery/semver#814 blocks the PR not bikecoders/ngx-deploy-npm#606

[dianjuar]

@rbalet, that was not a fix; was a workaround.

More info about the workaround:
jscutlery/semver#814 (comment)

Here, you can find an implementation of that workaround
https://github.com/bikecoders/ngx-deploy-npm/pull/606/files#r1634121869

[driatvak]

Hi @pavankjadda ,
Any updates on when support to angular v18 will be out ? 🙏

[pavankjadda]

@NetanelBasal please merge this whenever you get a chance.

[NetanelBasal]

The commit should be marked a BREAKING CHANGE based on the convention

[pavankjadda]

The commit should be marked a BREAKING CHANGE based on the convention

Done

[hakimio]

@NetanelBasal @pavankjadda the "breaking change" is not correct. The minimum Angular requirement in the package.json was not changed. It's still Angular 16.

[NetanelBasal]

@hakimio you're correct, my mistake. Never mind :)

[Drunkenpilot]

Got support error when install by npm

npm i @ngneat/query-devtools

Error detail

npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"^18.0.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@">=16.0.0 <18.0.0" from @ngneat/[email protected]
npm ERR! node_modules/@ngneat/query-devtools
npm ERR!   dev @ngneat/query-devtools@"*" from the root project

[pavankjadda]

@NetanelBasal could you release 3.0.0 version for dev tools as well?

[pavankjadda]

Got support error when install by npm

npm i @ngneat/query-devtools

Error detail

npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/core
npm ERR!   @angular/core@"^18.0.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/core@">=16.0.0 <18.0.0" from @ngneat/[email protected]
npm ERR! node_modules/@ngneat/query-devtools
npm ERR!   dev @ngneat/query-devtools@"*" from the root project

For now use npm i @ngneat/query-devtools --legacy-peer-deps

[NetanelBasal]

We first need to update the peer

[pavankjadda]

We first need to update the peer

it was already updated in last PR https://github.com/ngneat/query/blob/main/devtools/package.json#L13