Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): 🔥 add injectIsMutating and injectIsFetching #118

Merged
merged 6 commits into from
Nov 5, 2023

Conversation

luii
Copy link
Contributor

@luii luii commented Nov 5, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

stackblitz bot commented Nov 5, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@luii luii changed the title Feat/inject is helpers feat(query): 🔥 add injectIsMutating and injectIsFetching Nov 5, 2023
query/src/lib/is-fetching.ts Outdated Show resolved Hide resolved
query/src/lib/is-fetching.ts Outdated Show resolved Hide resolved
query/src/lib/is-fetching.ts Outdated Show resolved Hide resolved
query/src/lib/is-fetching.ts Show resolved Hide resolved
query/src/lib/is-fetching.ts Outdated Show resolved Hide resolved
query/src/lib/is-mutating.ts Outdated Show resolved Hide resolved
luii added 2 commits November 5, 2023 10:34
- Add teardown logic to dispose the internal subscription received from `MutationCache`
- Add `takeUntilDestroyed` to dispose of the observable when the `DestroyRef` signals it
- Add teardown logic to dispose the internal subscription received from `MutationCache`
- Add `takeUntilDestroyed` to dispose of the observable when the `DestroyRef` signals it
@NetanelBasal
Copy link
Member

Approved, can you please update the node version in our CI:

https://github.com/ngneat/query/actions/runs/6760534197/job/18374418728?pr=118

@NetanelBasal NetanelBasal merged commit 5505099 into ngneat:next Nov 5, 2023
1 check failed
@luii luii deleted the feat/injectIs-helpers branch November 7, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants