Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist to update maintainers team #2584

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Jun 17, 2024

  • chore: Add Slack Message from @jfy133
  • Try to use fancy checklists

@netlify /docs/checklists/maintainers_team_updates

@edmundmiller edmundmiller self-assigned this Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for nf-core ready!

Name Link
🔨 Latest commit 8688c0c
🔍 Latest deploy log https://app.netlify.com/sites/nf-core/deploys/66709e824457c90008623314
😎 Deploy Preview https://deploy-preview-2584--nf-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@edmundmiller edmundmiller requested a review from jfy133 June 17, 2024 20:37
@jfy133
Copy link
Member

jfy133 commented Jun 18, 2024

@edmundmiller I don't seem to be able to find the page (either by clicking through the website or guessing the URL), any ideas?

@jfy133
Copy link
Member

jfy133 commented Jun 18, 2024

Oh, wait found it!

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I sort of wonder if it makes sense to have this page exposed in the docs overview page... It's only basically for 3 people +maybe the maintainers team in an an emergency (technically)

subtitle: A step-by-step guide for changing of the guard
markdownPlugin: checklist
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Roughly once a year we review the maintainers team to ensure we have sufficient capacity to keep up with the community activity.
The following steps are what the maintainers team leads need to do during the review.

2. [ ] Ask for nominations in maintainers meeting, discuss and approve
3. [ ] Ask nominees
4. [ ] Once accepted, add to [#team-maintainers](https://nfcore.slack.com/archives/C043UU89KKQ) (and remove alumni/extras)
5. [ ] Once accepted, make PRs and merge in:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. [ ] Once accepted, make PRs and merge in:
5. [ ] Once accepted, make PRs to add/move to alumni members and merge in:

@mashehu
Copy link
Contributor

mashehu commented Jun 18, 2024

LGTM but I sort of wonder if it makes sense to have this page exposed in the docs overview page... It's only basically for 3 people +maybe the maintainers team in an an emergency (technically)

Yeah, had the same feeling...

@jfy133
Copy link
Member

jfy133 commented Jun 18, 2024

Can we leave the file in the same place but not index it in the docs overview section @mashehu ? Like 'hidden: true' in the header or something?

@mashehu
Copy link
Contributor

mashehu commented Jun 18, 2024

We don't have that option, not sure if we really want to have hidden files...

@jfy133
Copy link
Member

jfy133 commented Jun 18, 2024

Hidden only from being displayed in the overview, not that the page isn't accessible at all (in case I wasn't clear)

@edmundmiller
Copy link
Contributor Author

Hidden only from being displayed in the overview, not that the page isn't accessible at all (in case I wasn't clear)

Yeah, I agree with this. I don't think there's anything sensitive in there, but it would just be clutter that most people won't ever need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants