Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make xrdp-chkpriv script fancy #3340

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

metalefty
Copy link
Member

This PR also includes the following changes:


Here are actual outputs of xrdp-chkpriv script. Now it's obvious if xrdp is unprivilegeable.

image

image

image

- Do not include substitutedd xrdp-chkpriv into tarball
- Dot not install xrdp-chkpriv.in

While here, drop exec permission from *.c source file.
While here, drop exec permission from xrdp-chkpriv.in. The exec
permission will be granted to substituted xrdp-chkpriv script
during `make install` process.
@metalefty metalefty requested a review from matt335672 December 12, 2024 14:57
@metalefty metalefty changed the title make xrdp-chkpriv script funcy make xrdp-chkpriv script fancy Dec 12, 2024
Copy link
Member

@matt335672 matt335672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

I'd not come across the [ -t 1 ] trick before.

@metalefty metalefty merged commit e07cc72 into neutrinolabs:devel Dec 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants