Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert main pipelines to classes to avoid horrible long repeated signatures for handling slurm. #145

Open
JoeZiminski opened this issue Dec 6, 2023 · 4 comments
Open

Convert main pipelines to classes to avoid horrible long repeated signatures for handling slurm. #145

JoeZiminski opened this issue Dec 6, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@JoeZiminski
Copy link
Member

But keep the logic as straightforward as possible. Pipeline classes should not get very complex as they are very front-end.
@JoeZiminski JoeZiminski added the enhancement New feature or request label Dec 6, 2023
@JoeZiminski
Copy link
Member Author

need to check SLURM go to a config file. TBH all extra params should go the config file and out of the function signature.

@JoeZiminski
Copy link
Member Author

maybe used a named tuple to fix user-passed args on the class but allow easy conversion to dict etc. for slurm.

@JoeZiminski
Copy link
Member Author

Also tidy up tests, add --slow tests` and add to our internal tests.

@JoeZiminski
Copy link
Member Author

also find a place to document all and only input keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeZiminski