Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Better handle session and run name dictionary keys #123

Open
JoeZiminski opened this issue Sep 28, 2023 · 0 comments
Open

[Feature] Better handle session and run name dictionary keys #123

JoeZiminski opened this issue Sep 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@JoeZiminski
Copy link
Member

At present, the keys for sessions and runs in the dictionary use the user-input session and run keys, that matches the filename of the sessions and runs. Technically this (should?) be okay are they are just string, and there is no limit on the length a dictionary key can be. Nonetheless it seems error prone, maybe it is worth defining custom dictioanry key that holds both the folder name and a index, so the index is used by foldername is accessible if required.

see https://stackoverflow.com/questions/4901815/object-of-custom-type-as-dictionary-key

e.g subjects_and_sessions[0][0].save()  # save ses idx 0, run idx 0
subjects_and_sessions.keys()[0].folder_name()

maybe this could be better though.

@JoeZiminski JoeZiminski added the enhancement New feature or request label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant