Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo on Talk.php #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed a typo on Talk.php #116

wants to merge 4 commits into from

Conversation

naifmhd
Copy link

@naifmhd naifmhd commented Mar 12, 2018

the relationship was conversation but it was written as coversation.

Copy link
Owner

@nahid nahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep $this->config instead of config

@ndhaked
Copy link

ndhaked commented Jun 11, 2018

i need to delete messages from one sided like as facebook delete for me only..

@nahid
Copy link
Owner

nahid commented Jun 12, 2018

One side soft delete feature is already implemented

@ndhaked
Copy link

ndhaked commented Jun 14, 2018 via email

@peter279k
Copy link

@ndhaked, I think that it doesn't matter.
Just add the latest commit to fix $this->config request changes as @nahid says.
The Git can squash all to one commit and it can also use the merging approach when merging the PR.

Thanks.

@cfpinto
Copy link
Collaborator

cfpinto commented Oct 31, 2018

@naifmhd could you please do the changes that @nahid requested? We would like to merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants