New crawler #204
Merged
New crawler #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c949cfb.
|
FYI the readme still points to another outdated crawler as pointed out there: mwmbl/crawler-script#11 Also the script is missing a usage section imo. Adding a top docstring with clear instructions looks like a good idea to me. Edit: I suggest using pep723 to specify requirements Edit2: apparently pybloomfilter is needed but seems to be python2 only so I installed pybloomfiltermmap3 and it seems to work passed this issue at least Edit3: I'm stuck because it asks me for a MWMBL_API_KEY key but I can't find any info about how to get it. I'm so bullish for this project it's really too bad, I wanna help :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.