-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop 3.5 support #363
base: master
Are you sure you want to change the base?
drop 3.5 support #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mosquito I guess that
aio-pika/aio_pika/exceptions.py
Lines 14 to 23 in 5af608d
PAMQP_EXCEPTIONS = (pamqp.exceptions.PAMQPException,) + tuple( | |
pamqp.specification.ERRORS.values(), | |
) | |
CONNECTION_EXCEPTIONS = ( | |
RuntimeError, | |
ConnectionError, | |
OSError, | |
AMQPError, | |
) + PAMQP_EXCEPTIONS |
CONNECTION_EXCEPTIONS = (
RuntimeError,
ConnectionError,
OSError,
AMQPError,
pamqp.exceptions.PAMQPException,
)
PAMQP_EXCEPTIONS = (pamqp.exceptions.PAMQPException,) + tuple( | ||
pamqp.specification.ERRORS.values(), | ||
) | ||
PAMQP_EXCEPTIONS = (pamqp.exceptions.PAMQPException,) | ||
|
||
CONNECTION_EXCEPTIONS = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ConnectionError
can be removed because it inherits OSError
which is already exists here.
@@ -6,6 +6,7 @@ | |||
|
|||
import aiormq | |||
import aiormq.types | |||
from pamqp import commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other files you are making import pamqp.commands
, - I think it worth to do the same here so that it'll be the same everywhere.
No description provided.