Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sese] Backport fix env statement for 2.3.0 #41891

Merged
merged 3 commits into from
Nov 1, 2024
Merged

[sese] Backport fix env statement for 2.3.0 #41891

merged 3 commits into from
Nov 1, 2024
+16 −3

Conversation

SHIINASAMA
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

There was a problem with the original version of the cmake build script, the patch fixes this problem.

and the patch comes from upstream.

@SHIINASAMA SHIINASAMA marked this pull request as ready for review October 31, 2024 15:35
@WangWeiLin-MV WangWeiLin-MV changed the title [sese]: update to 2.3.0#2 [sese] Backport fix env statement for 2.3.0 Nov 1, 2024
@WangWeiLin-MV WangWeiLin-MV added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 1, 2024
WangWeiLin-MV
WangWeiLin-MV approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port installation tests pass with the following triplets:

  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Nov 1, 2024
@vicroms vicroms merged commit 93fcd03 into microsoft:master Nov 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SHIINASAMA @WangWeiLin-MV @vicroms