Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts] Test run with isolated python #41874

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Oct 30, 2024

REGRESSION: icu:x64-windows failed with BUILD_FAILED. If expected, add icu:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: python3:x64-windows failed with BUILD_FAILED. If expected, add python3:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: glad:x64-windows failed with BUILD_FAILED. If expected, add glad:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: clblas:x64-windows failed with BUILD_FAILED. If expected, add clblas:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: cmake:x64-windows cascaded, but it is required to pass. (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: cmake-user:x64-windows cascaded, but it is required to pass. (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: ctemplate:x64-windows failed with BUILD_FAILED. If expected, add ctemplate:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: godot-cpp:x64-windows failed with BUILD_FAILED. If expected, add godot-cpp:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: gtk:x64-windows cascaded, but it is required to pass. (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: qpid-proton:x64-windows failed with BUILD_FAILED. If expected, add qpid-proton:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: keystone:x64-windows failed with BUILD_FAILED. If expected, add keystone:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: libudis86:x64-windows failed with BUILD_FAILED. If expected, add libudis86:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: mesa:x64-windows failed with BUILD_FAILED. If expected, add mesa:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: open62541:x64-windows failed with BUILD_FAILED. If expected, add open62541:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: opencc:x64-windows failed with BUILD_FAILED. If expected, add opencc:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: openxr-loader:x64-windows failed with BUILD_FAILED. If expected, add openxr-loader:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: qt:x64-windows cascaded, but it is required to pass. (D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt).
REGRESSION: z3:x64-windows failed with BUILD_FAILED. If expected, add z3:x64-windows=fail to D:\a\_work\1\s\scripts\azure-pipelines/../ci.baseline.txt.

@FrankXie05 FrankXie05 self-assigned this Oct 31, 2024
@FrankXie05 FrankXie05 added the requires:testing Needs tests added before merging label Oct 31, 2024
@dg0yt dg0yt mentioned this pull request Oct 31, 2024
7 tasks
@Osyotr
Copy link
Contributor Author

Osyotr commented Oct 31, 2024

It's possible to keep ._pth file and be able to import scripts from current directory, but some ports (icu) expect non-isolated python because they explicitly set PYTHONPATH.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 1, 2024

Can you tell me how ports/vcpkg-get-python/vcpkg-port-config.cmake fits into this picture?

@Osyotr
Copy link
Contributor Author

Osyotr commented Nov 1, 2024

Can you tell me how ports/vcpkg-get-python/vcpkg-port-config.cmake fits into this picture?

vcpkg-get-python creates venv using python in CURRENT_HOST_INSTALLED_DIR. Venv ignores PYTHONPATH, so it can't be used for icu (though maybe it's icu that needs fixing). Also building python just to run scripts is an overkill.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 1, 2024

And then there is vcpkg-get-python-packages which deals with venv, doesn't build python, but insists on being asked for packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires:testing Needs tests added before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants