[Test] [libpq] Update to 17.0 #41846
Draft
+113
−1,081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2024 02:36
LilyWangLL
added
info:internal
dg0yt
reviewed
Oct 30, 2024
ports/libpq/portfile.cmake
Outdated
Comment on lines
99
to
101
| if(VCPKG_LIBRARY_LINKAGE STREQUAL "static") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin") | ||
| endif() |
There was a problem hiding this comment.
Manually removing the bin dir is a code smell.
And indeed, bin is removed before vcpkg_copy_tools(... AUTO_CLEAN) here.
There was a problem hiding this comment.
It also created the following dlls need to be removed:
note: debug/bin/libecpg.dll
note: debug/bin/libecpg_compat.dll
note: debug/bin/libpgtypes.dll
note: debug/bin/libpq.dll
note: debug/bin/pgevent.dll
note: bin/libecpg.dll
note: bin/libecpg_compat.dll
note: bin/libpgtypes.dll
note: bin/libpq.dll
note: bin/pgevent.dll
There was a problem hiding this comment.
Why build/install them first?
Comment on lines
-87
to
-89
| "client": { | ||
| "description": "Build all client tools and libraries" | ||
| }, |
There was a problem hiding this comment.
I would assume that we want to keep a feature which controls the installation of tools.
added 2 commits
November 1, 2024 01:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41747, update
libpqto 17.0.According to the upstream documentation, use
mesonto build the new version oflibpq.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file../vcpkg x-add-version --alland committing the result.Usage passed on
x64-windows.